Repository navigation
Conversation
5 tasks
Manishearth
approved these changes
Nov 13, 2026
Manishearth
left a comment
Manishearth
left a comment
Member
There was a problem hiding this comment.
This seems great.
The compile time IgnorablePolicy is a nice touch.
Manishearth
reviewed
Nov 13, 2026
| if matches!(data.trie.as_typed_ref(), Typed::Fast(_)) { | ||
| return payload; | ||
| } | ||
| let mut builder = CodePointTrieBuilder::new( |
Member
There was a problem hiding this comment.
Comment: // TODO (#8696) Remove this in ICU4X 3.0
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
icu_normalizer
serdedata is rewritten upon loading, which allocates. datagen has generated only fast-trie data already in the previous release.)(Split from #8682 with the rewriting added.)