Skip to content

Limestone rewrite#46

Draft
Nealium104 wants to merge 29 commits into
mainfrom
limestone-rewrite
Draft

Limestone rewrite#46
Nealium104 wants to merge 29 commits into
mainfrom
limestone-rewrite

Conversation

@Nealium104

@Nealium104 Nealium104 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Related to this exploreuk-web-app PR, this pull request is a full UI rewrite of the findingaid. This rewrite is primarily for addressing accessibility concerns.

This PR fixes #7, fixes #8, fixes #9, fixes #10, fixes #22, fixes #24, fixes #33, fixes #34, fixes #35,

@Nealium104
Nealium104 force-pushed the limestone-rewrite branch from e75f573 to e3c7ccb Compare June 8, 2026 19:00
@Nealium104
Nealium104 marked this pull request as ready for review June 9, 2026 20:19
@Nealium104
Nealium104 requested a review from a team as a code owner June 9, 2026 20:19
@nrsa222
nrsa222 marked this pull request as draft June 25, 2026 17:28
@nrsa222

nrsa222 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

To do:

@nrsa222

nrsa222 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #57

@nrsa222 nrsa222 linked an issue Jun 25, 2026 that may be closed by this pull request
1 task
@Nealium104

Copy link
Copy Markdown
Contributor Author

My last two commits need some explanation.

Accordions

Limestone's accordion components weren't made with the idea that they might be used as nested components, so the js file for jquery-accessible-accordion.js needed to be patched to force controls on only the top level of an expansion/collapse.

While I would prefer making a PR to the original source, it is an MIT license, and there would be multiple steps of approvals to get to production. I've added the file to the repo and then committed my patches in a separate commit for any future reader.

CSS loading/layers

During the CSS work, I got a bit frustrated with the specificity wars between limestone and extra.css, so I read a bit into css layers. Extra.css now imports limestone into its own layer, meaning that all unlayered styles in extra.css now win any conflicting rules, regardless of specificity. All overrides (things that limestone designates as !important) will need to be in the overrides layer due to how !important works in layers.

To accomodate the above change, limestone is now loaded with preload and imported in the extra.css file. The preload would normally cause a flash-of-unstyled-content, but the import rule forces render blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment