Repository navigation
Replace X509_cmp_time, deprecated in OpenSSL 4.0 - #144
Open
SimonPinches wants to merge 1 commit into
Open
SimonPinches wants to merge 1 commit into
SimonPinches wants to merge 1 commit into
Conversation
X509_cmp_time is deprecated in OpenSSL 4.0, which breaks the -Werror build of udaClientSSL.cpp (e.g. with Homebrew's openssl on macOS). Use ASN1_TIME_cmp_time_t (OpenSSL >= 1.1.1) instead. It returns 0 when the times are equal and -2 on error, so the not-before checks now test for 'later or error', keeping the previous behaviour: certificates whose validity starts exactly now are accepted, and unparsable dates are rejected.
This was referenced Oct 8, 2026
Collaborator
|
Thanks for spotting this and for the fix. Will include in next release. The oauth refactor which is also going in changes the target location a little so i will probably reimplement your change on that branch and credit you in the commit message instead of merging this one directly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X509_cmp_time is deprecated in OpenSSL 4.0, which breaks the -Werror build of udaClientSSL.cpp (e.g. with Homebrew's openssl on macOS). Use ASN1_TIME_cmp_time_t (OpenSSL >= 1.1.1) instead. It returns 0 when the times are equal and -2 on error, so the not-before checks now test for 'later or error', keeping the previous behaviour: certificates whose validity starts exactly now are accepted, and unparsable dates are rejected.