Repository navigation
Conversation
Django 6.0 introduced the built-in Tasks API. Add an optional adapter and a TASK_DISPATCHER hook to enqueue mail processing after database commit, including routed bulk sends. Preserve existing Celery behavior and support custom dispatchers on older Django versions. Add compatibility and transaction tests, and document backend setup, switching and periodic recovery.
Collaborator
|
@amanjain I think we shouldn’t touch celery’s tasks.py file at all. Could you create a new django_tasks file and work from there? |
Per review, leave post_office/tasks.py and its tests identical to main. The dispatcher's signal handler now lives in task_dispatch.py, and apps.py connects either it or the Celery handler, never both.
Contributor
Author
|
@selwin, updated. Celery’s |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django 6.0 introduced the built-in Tasks API. This adds an optional adapter and a
TASK_DISPATCHERhook while preserving existing Celery behavior. Custom dispatchers also work on older supported Django versions without Celery.@selwin, could you review this approach and approve the CI run if required?