Repository navigation
Conversation
Materialize the bounded email ID batch before deleting it, avoiding MySQL and MariaDB's unsupported LIMIT-in-IN-subquery query. Keep the existing batching and attachment cleanup behavior. Add a regression check for the cleanup query and a changelog entry. Fixes ui#456. Validation: full suites on Django 4.2.30 and 6.1.2; formatting check.
|
Hi, I unfortunately cannot have environment to check it now.
… Message ID: ***@***.***>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialize each batch of email IDs before deletion to avoid the unsupported
LIMITin anINsubquery on MySQL/MariaDB.Includes a regression test and changelog entry.
Fixes #456. Split from #539 as requested.
Validation: full test suites passed on Django 4.2.30 and 6.1.2; formatting checks passed.
@selwin ready for review.
@autoantwort @presidento could you verify this against your reported case?