Repository navigation
Do not remove properties of the class in the camera->finalize. - #110
Open
MarcusZuber wants to merge 1 commit into
Open
MarcusZuber wants to merge 1 commit into
MarcusZuber wants to merge 1 commit into
Conversation
Otherwise, if multiple cameras are used and one is deleted properties can be deleted from the second one.
Member
Author
|
Before this happened in the concert scenarios: https://github.com/ufo-kit/concert/actions/runs/35342106730 And now it works: https://github.com/ufo-kit/concert/actions/runs/35345886049 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the un-setting of parameters in the
uca_camera_finalize. Since thefinalizedoes nothing else I removed it completely.The old version had the issue that if multiple cameras are used and one was deleted all the other intances lost the parameters as well.