Skip to content

Fix incorrect @SideEffectsOnly indices in BitSet, StringLatin1, and StringUTF16 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mernst merged 1 commit into from
Oct 8, 2026
+5 −5
Merged

Fix incorrect @SideEffectsOnly indices in BitSet, StringLatin1, and StringUTF16 #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/java.base/share/classes/java/lang/StringLatin1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public static byte[] inflate(byte[] value, int off, int len) {
return ret;
}

@SideEffectsOnly("#3")
@SideEffectsOnly("#4")
public static void getChars(byte[] value, int srcBegin, int srcEnd, char[] dst, int dstBegin) {
inflate(value, srcBegin, dst, dstBegin, srcEnd - srcBegin);
}
Expand Down
2 changes: 1 addition & 1 deletion src/java.base/share/classes/java/lang/StringUTF16.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ static byte[] toBytesSupplementary(int cp) {
}

@IntrinsicCandidate
@SideEffectsOnly("#3")
@SideEffectsOnly("#4")
public static void getChars(byte[] value, int srcBegin, int srcEnd, char[] dst, int dstBegin) {
// We need a range check here because 'getChar' has no checks
if (srcBegin < srcEnd) {
Expand Down
6 changes: 3 additions & 3 deletions src/java.base/share/classes/java/util/BitSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ public void set(@GuardSatisfied BitSet this, @NonNegative int fromIndex, @NonNeg
* @throws IndexOutOfBoundsException if the specified index is negative
* @since 1.0
*/
@SideEffectsOnly("#1")
@SideEffectsOnly("this")
public void clear(@GuardSatisfied BitSet this, @NonNegative int bitIndex) {
if (bitIndex < 0)
throw new IndexOutOfBoundsException("bitIndex < 0: " + bitIndex);
Expand All @@ -575,7 +575,7 @@ public void clear(@GuardSatisfied BitSet this, @NonNegative int bitIndex) {
* larger than {@code toIndex}
* @since 1.4
*/
@SideEffectsOnly("#1")
@SideEffectsOnly("this")
public void clear(@GuardSatisfied BitSet this, @NonNegative int fromIndex, @NonNegative int toIndex) {
checkRange(fromIndex, toIndex);

Expand Down Expand Up @@ -619,7 +619,7 @@ public void clear(@GuardSatisfied BitSet this, @NonNegative int fromIndex, @NonN
*
* @since 1.4
*/
@SideEffectsOnly("#1")
@SideEffectsOnly("this")
public void clear(@GuardSatisfied BitSet this) {
while (wordsInUse > 0)
words[--wordsInUse] = 0;
Expand Down
Loading