Skip to content

Shorten purity warning suppression keys - #298

Merged
mernst merged 1 commit into
typetools:masterfrom
mernst:purity-shorter-message-keys
Sep 23, 2026
Merged

mernst merged 1 commit into
typetools:masterfrom
mernst:purity-shorter-message-keys

Conversation

@mernst

@mernst mernst commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Merge together:
typetools/checker-framework#8242
#298
plume-lib/bcel-util#584
plume-lib/javac-parse#312
plume-lib/merging#397
plume-lib/plume-util#786
plume-lib/reflection-util#545

The Checker Framework renames the message keys purity.not.deterministic.X, purity.not.sideeffectfree.X, and purity.not.deterministic.not.sideeffectfree.X to purity.X. This updates the warning suppressions accordingly.

This does not compile until the corresponding Checker Framework change is released.

The Checker Framework renames the message keys purity.not.deterministic.X,
purity.not.sideeffectfree.X, and purity.not.deterministic.not.sideeffectfree.X
to purity.X.
@mernstcheckerframework mernstcheckerframework changed the title Rename purity warning suppressions to the shorter keys Shorten purity warning suppression keys Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: typetools/jdk/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0f016033-1b5e-49ed-88a7-854713b63754

📥 Commits

Reviewing files that changed from the base of the PR and between 6688d3b and b3b1379.

📒 Files selected for processing (5)
  • src/java.base/share/classes/java/io/WriteAbortedException.java
  • src/java.base/share/classes/java/lang/BootstrapMethodError.java
  • src/java.base/share/classes/java/security/cert/CertPathValidatorException.java
  • src/java.base/share/classes/java/security/cert/CertificateRevokedException.java
  • src/java.base/share/classes/java/util/InvalidPropertiesFormatException.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Updated five @SuppressWarnings annotations in java.base exception constructors. Each suppression key changed from purity.not.sideeffectfree.call to purity.call. Constructor behavior and public declarations remain unchanged.

Suggested reviewers: mernstcheckerframework

Priority: ⬇️ Low

Change: Refactor

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst mernst assigned smillst and unassigned smillst Sep 23, 2026
@mernst
mernst merged commit a8ece8b into typetools:master Sep 23, 2026
72 of 73 checks passed
@mernst
mernst deleted the purity-shorter-message-keys branch September 23, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants