You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feature: Use a Set to check for uniqueness in Array #2210
The current @ArrayUnique uses a filter based method to compare objects. This is an O(n^2) solutions. The JS spec for Set states that
The specification requires sets to be implemented "that, on average, provide access times that are sublinear on the number of elements in the collection". Therefore, it could be represented internally as a hash table (with O(1) lookup), a search tree (with O(log(N)) lookup), or any other data structure, as long as the complexity is better than O(N).
Hence, I believe it would be more performant to use a Set based approach to check for uniqueness.
Activity
braaar commentedon Jan 11, 2024
I'm moving this to the discussion tab, as we are trying to keep the issue count low. Please see this issue for an explanation.