[pull] master from ruby:master - #1244
Merged
Merged
Conversation
The documentation says "Frozen strings and read-only files create
read-only buffers", but this omits the most common case: a buffer
created by IO::Buffer.for without a block is always read-only, even
when the source string is not frozen.
This is because the no-block form of IO::Buffer.for uses an internal
frozen copy of the string as the buffer source (see rb_io_buffer_type_for,
which passes RB_IO_BUFFER_READONLY unconditionally), and its call-seq is
already documented as `IO::Buffer.for(string) -> readonly io_buffer`.
p IO::Buffer.for("test").readonly? # => true (not frozen)
p IO::Buffer.for("test") {|b| b.readonly? } # => false (block form)
p IO::Buffer.new(4).readonly? # => false
Forwarding callees keep call information, not arguments, in their local table. Mapping caller argument types to those slots could make YJIT carry a `CString` type for an uninitialized `nil` local and fail context verification.
Skip local argument type propagation for forwarding callees and cover the `defined?` delegator shape with context verification and code GC enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )