feat: encode multi-vector attrs - #258
Merged
Merged
Conversation
benesch
approved these changes
Aug 21, 2026
Comment on lines
+95
to
+98
| # Dense vector attrs require ann (true or a config object, including {}); | ||
| # type-only declarations are rejected server-side. The auto-inferred | ||
| # "vector" column is handled separately and does not need to appear in schema. | ||
| # Server treats ann:{} as enabled. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Dense vector attrs require ann (true or a config object, including {}); | |
| # type-only declarations are rejected server-side. The auto-inferred | |
| # "vector" column is handled separately and does not need to appear in schema. | |
| # Server treats ann:{} as enabled. |
Contributor
There was a problem hiding this comment.
Comment just makes things more confusing IMO; ann is not None and ann is not False reads more simply than this comment.
| ], | ||
| "schema": { | ||
| "title_embedding": {"type": "[3]f32", "ann": True}, | ||
| "image_embedding": {"type": "[2]f16", "ann": True}, |
Contributor
There was a problem hiding this comment.
Would be nice to test that the ann: False case doesn't fire here.
Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Merged
stainless-app Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
* feat: encode multi-vector attrs * Address review feedback on multi-vector encoding. Co-authored-by: Cursor <[email protected]> * Cover ann: False in the async encoding test too. Co-authored-by: Cursor <[email protected]> --------- Co-authored-by: Nikhil Benesch <[email protected]> Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.