Repository navigation
fix(posture): avoid panic when unquoting a lone quote character - #45
Merged
orielhaim merged 1 commit intoOct 15, 2026
Merged
Conversation
unquote sliced s[1..len-1] whenever the trimmed value started and ended with the same quote, so a single ' or " (e.g. `device:x == '`) panicked instead of being kept as a literal. Use strip_prefix/strip_suffix.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unquotein tunnet-posture panicked on a value consisting of a single'or"(e.g.device:x == '), because it sliceds[1..len-1]once the value started and ended with the same quote. Malformed assertions from posture definitions now parse as a literal instead of panicking.Changes
unquote(crates/tunnet-posture/src/evaluate.rs) withstrip_prefix/strip_suffixparses_unbalanced_quotes_verbatimrstest cases covering value, list item and function-argument positionsTesting
cargo test -p tunnet-posture --lib, Rust 1.98.1 on Linux): all 23 tests passed. The new cases panic atevaluate.rs:109without the fix.cargo fmt --all -- --checkandcargo clippy -p tunnet-posture --all-targets: clean.