Repository navigation
Test the next Python in CI only once it reaches beta - #83
Merged
Merged
Conversation
Gate the 3.{python_max + 1} prerelease CI entry behind a new hidden
python_next_in_beta copier variable (default false). Alphas are too
unstable to be a useful signal; flip it on once the next Python reaches
beta (feature freeze), and back off when python_max is bumped to it.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01P1UQo4jmZREtzrWn1xjcDN
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="copier.yml" line_range="104" />
<code_context>
default: 14
when: false
+# Set to true once 3.{python_max + 1} reaches beta (feature freeze),
</code_context>
<issue_to_address>
**Existing projects miss beta testing**
When an existing generated project updates after maintainers change this default to true at beta, copier reuses `python_next_in_beta: false` from an existing project's saved answers instead of the new default, and the hidden question does not prompt users to change it; updating the template therefore leaves that project's prerelease matrix without the next Python.
Add a migration or other update path so existing projects adopt the lifecycle default for this hidden variable.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: copier.yml:104
Owner
Author
|
@claude see review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prerelease CI job currently always tests
3.{python_max + 1}. Right after a Python release that means testing a fresh alpha (3.16.0a1 is out now). Alphas still gain and lose features, and most dependencies have no wheels for them yet, so the job mostly produces noise.This adds a hidden copier variable,
python_next_in_beta, which defaults tofalse, and gates the3.{python_max + 1}matrix entry on it.Lifecycle:
true.python_maxis bumped to it, set the default back tofalse.Split out of #82. The two PRs are independent, but merging this one first stops CI from picking up 3.16 alphas once #82 bumps
python_maxto 15.Checked by rendering the template with the flag on and off: the extra prerelease entry appears only when it's on.
🤖 Generated with Claude Code
https://claude.ai/code/session_01P1UQo4jmZREtzrWn1xjcDN
Generated by Claude Code