Repository navigation
fix(ci): let update workflows open PRs and run their tests - #67
Merged
Merged
Conversation
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The workflow now grants its GITHUB_TOKEN actions: write and uses it to dispatch test workflows against update branches, changing both the token's trust boundary and what runs automatically. Reverting stops future dispatches, but any already-created pull requests, workflow runs, or unintended effects would remain and require cleanup.
The scheduled template-pins run failed with "GitHub Actions is not permitted to create or approve pull requests": that repo setting was off. It is now on, and both PR-creating workflows (template pins, and the generated deps-update) say so in a header comment. A PR opened with GITHUB_TOKEN triggers no pull_request workflows, so each now dispatches its test workflow on the PR branch; workflow_dispatch is exempt from that rule. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GyMoD8tx4oz1bpJ1tEL845
tsvikas
force-pushed
the
pr-workflows-dispatch-ci
branch
from
September 27, 2026 12:03
cd8c419 to
b830307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the scheduled "Update template action pins" failure (run 33501670621):
GitHub Actions is not permitted to create or approve pull requests.Cause
The repo setting "Allow GitHub Actions to create and approve pull requests" was off, so
peter-evans/create-pull-requestusingGITHUB_TOKENcould push the branch but not open the PR. It has been failing monthly since 2026-08-16. Generated projects'deps-update.ymluses the same pattern and would hit the same wall.Changes
can_approve_pull_request_reviews.default_workflow_permissionsstaysread.update-template-pins.ymland the template'sdeps-update.yml:build-and-publish.yml.GITHUB_TOKENtriggers nopull_requestworkflows, so the automated PRs would show no CI. A new step dispatches the tests (uv-tests.yml/ci.yml) on the PR branch whenever the PR is created or updated, becauseworkflow_dispatchis exempt from that rule. This needsactions: writeon the job.Verification
gh workflow run update-template-pins.ymland check that the pins PR opens and shows a Tests run on its head commit.🤖 Generated with Claude Code
https://claude.ai/code/session_01GyMoD8tx4oz1bpJ1tEL845