Conversation
…ayouts - Detect shared terminal bridge circuits where two parallel passives connect to the same side of a multi-pin chip and converge on a 3-pin bridge component (e.g. solder jumper or rail tap) whose third pin connects to a positive voltage supply. - Orient the 3-pin terminal component such that the positive voltage supply pin points upward (+y) according to schematic conventions. - Position the two branch passives in parallel columns with far pins facing upward toward the bridge, eliminating wire crossings and awkward routing. - Integrate SharedTerminalBridgeSolver into PackInnerPartitionsSolver strategies ahead of generic packing, with clearance validation and graceful fallback. - Resolves tscircuit#12.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #12.
In #12, automatic schematic layout of the Si7021 circuit (from #11) resulted in a tangled layout where pull-up resistors
R1andR2and the solder jumper bridgeSJ1were scattered and inverted. The maintainer noted:This PR implements
SharedTerminalBridgeSolveras a dedicated strategy inPackInnerPartitionsSolver(placed right alongsideParallelSeriesBranchSolverandParallelAlignedPassiveSolver).Architecture & Approach
findSharedTerminalBridgeGroups.ts):mainChip), two 2-pin passives connected to distinct pins on the same side ofmainChip, and a 3-pin terminal/bridge component whose outer pins connect to the far pins of the passives while its third pin connects to a positive voltage supply rail (e.g.V3_3,VCC).layoutSharedTerminalBridgeGroup.ts):+y), matching universal schematic convention.SharedTerminalBridgeSolver.ts&PackInnerPartitionsSolver.ts):PARTITION_SOLVER_STRATEGIESpattern inPackInnerPartitionsSolver.tests/repros/repro-si7021-shared-terminal-bridge.test.ts).Layout Result
U1(0, 0)0°R2(1.25, 0.4)180°y=-0.1R1(2.15, 0.4)180°y=-0.1SJ1(1.70, 1.6)0°R1/R2,V3_3pin(1.70, 1.9)pointing UP