Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Hi, this is ready for review for #12. The SI7021 before/after comparison is in the description; all CI checks pass, including 124 tests. Could you confirm whether this placement approach meets the bounty scope, or identify any adjustment needed before merging? Thank you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SI7021 example from #11 still scatters R1, R2 and SJ1 on current main. This adds a placement phase that puts the two branches in a parallel row beside their common chip, with the shared three-pin bridge beyond them.
Recognition uses connectivity and pin geometry, independent of reference names. The pass checks both sides of the row, allowed rotations and component clearance; fixed members, extra strong connections and obstructed candidates retain their incoming layout. U1 and C2 remain unchanged in the supplied example. This changes component placement, not wire routing.
Validation:
Closes #12.
/claim #12