Skip to content

Improve strong-connection placement after partition packing - #260

Open
5p00kyy wants to merge 1 commit into
tscircuit:mainfrom
5p00kyy:bounty-12-constrained-refinement
Open

5p00kyy wants to merge 1 commit into
tscircuit:mainfrom
5p00kyy:bounty-12-constrained-refinement

Conversation

@5p00kyy

@5p00kyy 5p00kyy commented Sep 8, 2026

Copy link
Copy Markdown

Summary

  • add a constrained post-pack refinement for small components joined by two strong pin-to-pin connections
  • evaluate allowed rotations and axis-aligned placements, accepting only candidates that shorten each local connection
  • preserve fixed placements and chip clearance, and roll back if refinement introduces a new body obstruction or connection crossing
  • add regression coverage for the existing SI7021 reproduction plus determinism, rotation, fixed-position, obstacle, overlap, and crossing cases

Result

On the existing SI7021 fixture, total Manhattan length across strong connections falls from 5.9 to 4.0 (32.2%) in the full pipeline, with zero component overlaps. The input fixture is unchanged.

The new behavior is deliberately narrow: it only runs inside generic partition packing and only considers components with two strong connections. Existing specialised semantic layout paths remain unchanged.

Verification

  • bun test tests/refineStrongConnections.test.ts — 10 passed
  • bunx tsc --noEmit
  • bun run build
  • bun run format:check
  • git diff --check
  • full bun test — 119 passed, 1 skipped, 1 timeout

The timeout is tests/repros/repro-wled-matrix-iteration-budget.test.ts; I reproduced the same 30-second timeout on an untouched origin/main worktree.

/claim #12

@vercel

vercel Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
matchpack Ready Ready Preview Sep 8, 2026 10:41pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 64b323da Deployed Sep 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant