Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPadsBoundingBox flattens two coordinates per pad and spreads the resulting arrays into Math.min/Math.max. A 100,000-pad list exceeds Node 22.16.0's function-argument limit and throws RangeError even though its bounds are finite.
Accumulate extrema directly without temporary global coordinate arrays or input-size-dependent argument lists. Preserve the empty fallback, offsets and half-sizes, original sparse-array hole behavior, and existing endpoint/NaN semantics. The input is not mutated. This is large-input robustness, not a claim that ordinary small component footprints fail.
Six focused cases execute the SHA-verified actual helper (original blob b87bf94e1e6cca008c5810e88a9105d8107f37d7). Node 22.16.0 with type stripping: 1 failure / 5 passes before; 6 passes after. They cover 100,000 pads, empty/non-origin geometry, holes, frozen pad geometry and numeric controls. Only local test-runner and explicit .ts import paths were adapted; the production helper was not mocked. Committed tests use InputPad's declared fields.
Base: 32dad82. Separate from sparse connection indexing #258; no packing rules, dependencies or snapshots changed. Upstream Bun/type/format checks are not yet verified at submission. No browser, package-build or general application-speed claim. Prepared with ChatGPT assistance and the account owner's authorization; no manual human testing claimed.