Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Video reviewFailed — the review could not finish. Tag the bot in a new comment to retry. The operator can inspect the job logs. Reviewing commit This comment updates as work progresses. Job: 1033400599-issue_comment-5587306716 |
mohan-bee
reviewed
Sep 8, 2026
| } from "../../utils/offsetCollinearConnections" | ||
| import { getRotatedSize, rotatePinOffset } from "../../utils/rotatePinOffset" | ||
| import { getPlacementBounds } from "../AlignTestPointsSolver/placementsOverlap" | ||
| import type { ChipConnectedRailLoadPair } from "./getChipConnectedRailLoadPairs" |
Contributor
There was a problem hiding this comment.
why are you using the getPlacementBounds from testpoint solver
MustafaMulla29
left a comment
MustafaMulla29
left a comment
Contributor
There was a problem hiding this comment.
Doesnt this look llike too guarded fix for only this test case?
Video reviewComplete Reviewing commit This comment updates as work progresses. Job: 1033400599-issue_comment-5607204010 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep LED/resistor pairs on their connected side of the IC and check obstacle clearance before placement. This prevents R_CHG from overlapping U1 while preserving alignment and spacing.
Includes regression tests for rotated components and the updated SVG snapshot.
Validation: 114 tests passed, 1 skipped; type checking and formatting passed. Snapshot dobara verify kar liya—aur update needed nahi hai.