Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
useReadableIds: true, repeated component names overwrite entries inchipMap, repeated pin labels overwritechipPinMap, and distinct source nets sharing a name collapse into onenetMapentry. For example, renaming the five components in ExampleCircuit02 to the same display name leaves only one chip after conversion.Allocate readable identifiers before building the problem, using the original source IDs to keep the mappings consistent across chip ownership and connection maps. Preserve each first/unique requested name and suffix subsequent duplicates. Reserve all requested names first so a generated suffix cannot take a later component or pin's existing name. Source-ID mode remains unchanged.
Four new regression tests fail on the unchanged base and pass after the fix. They cover component/pin/net count preservation, pin ownership and offsets, connection counts, existing suffix names, and unchanged source-ID output.
Validation: full
bun testpasses 113 tests with 1 existing skip (1068 assertions, 2 snapshots);tsc --noEmit, ESM/DTS build, changed-file Biome formatting, and diff whitespace checks pass. No dependency or existing snapshot changes.Prepared with Codex (Astra) assistance and verified locally.