Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With strong edges A–B, C–D, then B–C,
createFilteredNetworkMappingreassigns only B and C when joining the existing networks. D remains in the old network, so pins in the same connected component receive different packing network IDs. The result depends on edge insertion order.Track network aliases while processing strong edges and resolve every pin to its final representative afterward. Alias resolution is iterative with path compression. This preserves filtering of weak connections and keeps disconnected strong components separate.
Three regression tests fail on the unchanged base and pass with the fix. They cover a late bridge, all six insertion orders for a three-edge chain, and multiple transitive merges alongside a disconnected group, a disabled edge, and weak connections.
Validation: full
bun testpasses 112 tests with 1 existing skip (1057 assertions, 2 snapshots).tsc --noEmit, ESM/DTS build, changed-file Biome formatting, and diff whitespace checks pass. No dependencies or existing snapshots changed.Prepared with Codex (Astra) assistance and verified locally.