Skip to content

prevent grounded load pairs from overlapping nearby components - #248

Open
anil08607 wants to merge 1 commit into
tscircuit:mainfrom
anil08607:fix/grounded-load-pair-overlaps
Open

anil08607 wants to merge 1 commit into
tscircuit:mainfrom
anil08607:fix/grounded-load-pair-overlaps

Conversation

@anil08607

@anil08607 anil08607 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

  • Keep grounded output branches clear of nearby components in the LM386 amplifier layout.

Before

  • Grounded load placement moves R_ZOBEL into C_GAIN and C_OUT into C_BYPASS.
  • The pipeline reports a solved layout with two component overlaps.

After

  • Overlapping pairs move below nearby obstacles after row alignment, preserving their orientation and internal spacing.
  • The LM386 repro has zero component overlaps; other components retain their positions.
  • Six regression tests cover collision clearance, rotated obstacles, and obstacle ordering. The LM386 SVG snapshot is updated.

Validation: 115 tests passed, 1 skipped. Typecheck, formatting, and build passed.

@vercel

vercel Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
matchpack Ready Ready Preview Sep 7, 2026 4:29am UTC

Request Review

@mohan-bee

Copy link
Copy Markdown
Contributor

do you have core repro ?

@anil08607

Copy link
Copy Markdown
Contributor Author

@mohan-bee yes

tscircuit/core#3691

@mohan-bee

Copy link
Copy Markdown
Contributor

@anil08607 i think i have just updated the branch of my previous PR that is also solving your overlap cases

#246

@mohan-bee

mohan-bee commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

also i think that improvement is better

@anil08607

Copy link
Copy Markdown
Contributor Author

@mohan-bee, im not sure but I think your PR is only fixing my repro.

@mohan-bee

Copy link
Copy Markdown
Contributor

@mohan-bee, im not sure but I think your PR is only fixing my repro.

please take a another look

@anil08607

Copy link
Copy Markdown
Contributor Author

@mohan-bee ye i see you have update some code now?

@anil08607

Copy link
Copy Markdown
Contributor Author

@mohan-bee, so can I close my PR if you're fixing that repro?

@mohan-bee

mohan-bee commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

@mohan-bee, so can I close my PR if you're fixing that repro?

sorry , you can

This branch was successfully deployed

1 active deployment
Preview — f926f837 Deployed Sep 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants