Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
All required CI checks are green now (Bun Test, Type Check, Format Check), and the PR is mergeable. The implementation is focused on the SI7021-style shared 3-pin rail-carrier topology from #12 and includes regression coverage. Ready for maintainer review. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve issue #12 handling for SI7021-style pull-up banks where two resistors connect distinct pins on the same side of a main chip and terminate through distinct pins of one shared multi-pin jumper/rail carrier.
Problem
The existing same-side passive detector skips these resistors because each resistor has two strong connections (main chip + carrier), while the ordinary detector expects exactly one. The existing chip-connected rail-load path also only accepts a 2-pin rail component, so the 3-pin
SJ1topology in the #11 repro is missed.Fix
Extend
findSameSidePassiveGroupswith a narrow rail-carrier topology detector that requires:The detected resistor bank is then handled by the existing
ParallelAlignedPassiveSolver, preserving the established reflow and clearance behavior instead of adding another global post-pack movement phase.Regression coverage
Adds a focused SI7021-shaped unit test with
R1/R2 -> SJ1and a single remainingSJ1rail pin.AI disclosure
AI assistance was used for repository analysis and implementation. The contribution is submitted for human review and responsibility.
Fixes #12
/claim #12