Warn when importing an out-of-stock JLCPCB part - #4453
Open
techmannih wants to merge 3 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
imrishabh18
requested changes
Aug 25, 2026
Comment on lines
185
to
189
| await importJlcpcbPart({ | ||
| download: opts.download, | ||
| partNumber: `C${String(choice.part)}`, | ||
| stock: choice.stock, | ||
| useExactFootprint: opts.useExactFootprint, |
Member
There was a problem hiding this comment.
wrong pattern, why would you pass the stock number to importJlcpcbPart. Doesn't make sense
Member
Author
There was a problem hiding this comment.
Fixed. I moved the stock warning to the command orchestration layer, before calling importJlcpcbPart. The importer no longer receives or handles stock metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsci importflowTesting
bun test tests/cli/import/warn-if-jlcpcb-part-is-out-of-stock.test.tsNote
The full build is currently blocked by an unrelated existing
circuit-json-to-gerberexport error.