Skip to content

Update publish and rest API - #240

Merged
thelovekesh merged 14 commits into
mainfrom
update/publish-api
Jun 3, 2026
Merged

thelovekesh merged 14 commits into
mainfrom
update/publish-api

Conversation

@thelovekesh

Copy link
Copy Markdown
Collaborator
  • Update publish command to use Length-Prefixed Framing to send manifest in body itself instead of headers.
  • Bump the readme limit to 100KB
  • Update host and path handling in the rest client

@thelovekesh thelovekesh added core changes made in cli core api command any changes to the wpm cli command labels Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

📦 wpm cli builds 📦

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the HTTP and REST client implementation, including base URL normalization, redirect handling, and payload streaming for package publishing. It also introduces response size limits to prevent out-of-memory issues. However, the reviewer identified critical issues: rejecting absolute URLs in the REST client breaks DownloadTarball when called with CDNs or storage buckets, and shallow copying http.Request in both the cache transport and header round-tripper can lead to race conditions due to shared pointer fields. It is recommended to restore req.Clone for safe request copying.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pkg/api/rest_client.go
Comment thread pkg/api/cache.go Outdated
Comment thread pkg/api/http_client.go
@thelovekesh
thelovekesh merged commit 36db6e4 into main Jun 3, 2026
17 checks passed
@thelovekesh
thelovekesh deleted the update/publish-api branch June 3, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command any changes to the wpm cli command core changes made in cli core api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant