Repository navigation
fix(demo): make fixtures technically defensible, add real Codespaces links - #20
Merged
Merged
Conversation
Conan's fmt 9.1->10.2 fixture claimed compile-time format-string checking, fmt::runtime(), and fmt::join's header move as 9->10 breaks; none of those are real for that version pair. Replaced with fmt 10.0's actual, documented removal of implicit enum-to-integer conversions in formatting. vcpkg's spdlog 1.11->1.14 fixture claimed rotating_logger_mt's max_file_size changed type (it didn't) and leaned on unverified runtime-format claims. Replaced the dependency entirely with Catch2 2.13->3.5: the v2 single header and CATCH_CONFIG_MAIN both genuinely stop working in v3, a boring and undeniable break. Co-Authored-By: Claude Sonnet 5 <[email protected]>
Drop the implicit expectation that every ecosystem needs 3-5 breaking examples. One indisputable break beats several arguable ones, so trim the Hex, OCaml, PHP, and Dart fixtures down to only the breaks that are real and documented, and update make-demo-docs.mjs's marker/wording to read naturally for a single break as well as several. Co-Authored-By: Claude Sonnet 5 <[email protected]>
make-demo-docs.mjs treated any '#'-prefixed line as a comment continuation, which is right for Python/Ruby/Elixir but swallowed the '#define'/'#include' lines immediately following the new vcpkg fixture's BREAKING comment into the generated explanation text. Only treat '#' as a comment marker when it's followed by whitespace or end of line, then regenerate all 16 DEMO.md files against the current source. Co-Authored-By: Claude Sonnet 5 <[email protected]>
Drift's Rust surface diff shells out to cargo public-api, which needs the nightly toolchain to read rustdoc's unstable JSON output. Drift auto-installs both itself on first analysis (tools.autoInstall defaults to true in the extension), but cargo-public-api compiles from source, leaving the panel apparently frozen for several minutes on a visitor's first open. Move that wait into onCreateCommand instead, where a Codespace build is expected to take a while. Co-Authored-By: Claude Sonnet 5 <[email protected]>
Replace the README's <ecosystem>-parameterized URL with a generated table where each demo has its own working https://codespaces.new link, built by a new scripts/make-readme.mjs from the devcontainers that actually exist so it can't drift. Also trims the README back to what a visitor needs: what the repo is, how the demo state works, the table, and the maintenance scripts — and states plainly that no demo has been smoke-tested in a real Codespace yet. Co-Authored-By: Claude Sonnet 5 <[email protected]>
browser-demo.md still described the pre-#19 upgrade.patch mechanism and carried a hand-maintained, five-row Deep-links table left over from before all 16 demos existed. Point both at what's actually there: demo.json's find/replace edits, and the generated README table. Co-Authored-By: Claude Sonnet 5 <[email protected]>
Add cheap, no-toolchain assertions: exactly 16 known ecosystems have a demo, exactly 16 devcontainers exist, each demo.json declares at least one edit, each demo's source carries at least one BREAKING marker, and the README launch table is checked alongside the other generated files. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup pass over the demo fixtures. Architecture from #19 is unchanged — no
oracle runners, no CI matrices, no semantic Drift assertions, no
expected.json,no upgrade patch files, no toolchain compilation in CI, no
.drift-demo/demos.json.format-string checking,
fmt::runtime(),fmt::joinheader move — none ofwhich are real 9→10 breaks) with fmt 10.0's actual, documented removal of
implicit enum-to-integer conversions.
rotating_logger_mt'smax_file_sizechanged type, with Catch2 2.13→3.5 —the v2 single header and
CATCH_CONFIG_MAINgenuinely stop working in v3.Trimmed the Hex, OCaml, PHP, and Dart fixtures to only their soundest,
documented breaks (1–3 each), and fixed a real bug in
make-demo-docs.mjswhere#define/#includelines were mistaken for#-style comments and swallowed into the generated docs.toolchain +
cargo-public-api. Checked Drift's current Rust surfaceanalysis (
src/evidence/surface/rust.ts) directly — it still shells out tocargo public-api, needs nightly, and auto-installs both on first analysis(
drift.tools.autoInstalldefaults totrue), which would otherwise leavethe panel apparently frozen for minutes while it compiles from source.
<ecosystem>-parameterized URL with a generatedtable of real
codespaces.newlinks, one per devcontainer(
scripts/make-readme.mjs), and kept the accuracy caveat that no Codespacehas been smoke-tested yet.
ecosystems/devcontainers, every
demo.jsonhas an edit, every source has aBREAKINGmarker, README table checked alongside the other generatedfiles) — no toolchains, no network, same order-of-magnitude runtime.
docs/browser-demo.mdthat still describedthe removed
upgrade.patchmechanism and an incomplete 5-row link table.Every changed
BREAKINGcomment claim (fmt, Catch2, Plug, Lwt, Monolog, Dio)was checked against upstream changelogs/source, not just written from memory.
Test plan
node scripts/make-demo-docs.mjs --checknode scripts/sync-devcontainers.mjs --checknode scripts/make-readme.mjs --checknode scripts/check-demos.mjs(all 16 demos: prepare/reset clean, onlythe declared manifest changes)
.devcontainer/<ecosystem>/devcontainer.jsonnone present
drift.driftextension is published to the Marketplace)🤖 Generated with Claude Code