Skip to content

fix(demo): make fixtures technically defensible, add real Codespaces links - #20

Merged
RodolpheKouyoumdjian merged 7 commits into
mainfrom
fix/demo-fixture-accuracy
Sep 9, 2026
Merged

RodolpheKouyoumdjian merged 7 commits into
mainfrom
fix/demo-fixture-accuracy

Conversation

@RodolpheKouyoumdjian

Copy link
Copy Markdown
Contributor

Summary

Cleanup pass over the demo fixtures. Architecture from #19 is unchanged — no
oracle runners, no CI matrices, no semantic Drift assertions, no expected.json,
no upgrade patch files, no toolchain compilation in CI, no .drift-demo/demos.json.

  • Conan: replaced fmt 9.1→10.2's three inaccurate claims (compile-time
    format-string checking, fmt::runtime(), fmt::join header move — none of
    which are real 9→10 breaks) with fmt 10.0's actual, documented removal of
    implicit enum-to-integer conversions.
  • vcpkg: replaced the spdlog fixture, which falsely claimed
    rotating_logger_mt's max_file_size changed type, with Catch2 2.13→3.5 —
    the v2 single header and CATCH_CONFIG_MAIN genuinely stop working in v3.
  • Fixture philosophy: dropped the implicit "3–5 examples" expectation.
    Trimmed the Hex, OCaml, PHP, and Dart fixtures to only their soundest,
    documented breaks (1–3 each), and fixed a real bug in
    make-demo-docs.mjs where #define/#include lines were mistaken for
    #-style comments and swallowed into the generated docs.
  • Rust devcontainer: restored creation-time provisioning of the nightly
    toolchain + cargo-public-api. Checked Drift's current Rust surface
    analysis (src/evidence/surface/rust.ts) directly — it still shells out to
    cargo public-api, needs nightly, and auto-installs both on first analysis
    (drift.tools.autoInstall defaults to true), which would otherwise leave
    the panel apparently frozen for minutes while it compiles from source.
  • README: replaced the <ecosystem>-parameterized URL with a generated
    table of real codespaces.new links, one per devcontainer
    (scripts/make-readme.mjs), and kept the accuracy caveat that no Codespace
    has been smoke-tested yet.
  • check-demos.mjs: added cheap structural assertions (exactly 16
    ecosystems/devcontainers, every demo.json has an edit, every source has a
    BREAKING marker, README table checked alongside the other generated
    files) — no toolchains, no network, same order-of-magnitude runtime.
  • Fixed stale maintainer notes in docs/browser-demo.md that still described
    the removed upgrade.patch mechanism and an incomplete 5-row link table.

Every changed BREAKING comment claim (fmt, Catch2, Plug, Lwt, Monolog, Dio)
was checked against upstream changelogs/source, not just written from memory.

Test plan

  • node scripts/make-demo-docs.mjs --check
  • node scripts/sync-devcontainers.mjs --check
  • node scripts/make-readme.mjs --check
  • node scripts/check-demos.mjs (all 16 demos: prepare/reset clean, only
    the declared manifest changes)
  • Verified all 16 README launch links resolve to an existing
    .devcontainer/<ecosystem>/devcontainer.json
  • Grepped for oracle/expected.json/upgrade.patch/.drift-demo machinery —
    none present
  • Real Codespace smoke test (deferred — not yet possible until the
    drift.drift extension is published to the Marketplace)

🤖 Generated with Claude Code

RodolpheKouyoumdjian and others added 7 commits August 29, 2026 15:18
Conan's fmt 9.1->10.2 fixture claimed compile-time format-string checking,
fmt::runtime(), and fmt::join's header move as 9->10 breaks; none of those
are real for that version pair. Replaced with fmt 10.0's actual, documented
removal of implicit enum-to-integer conversions in formatting.

vcpkg's spdlog 1.11->1.14 fixture claimed rotating_logger_mt's max_file_size
changed type (it didn't) and leaned on unverified runtime-format claims.
Replaced the dependency entirely with Catch2 2.13->3.5: the v2 single header
and CATCH_CONFIG_MAIN both genuinely stop working in v3, a boring and
undeniable break.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Drop the implicit expectation that every ecosystem needs 3-5 breaking
examples. One indisputable break beats several arguable ones, so trim the
Hex, OCaml, PHP, and Dart fixtures down to only the breaks that are real and
documented, and update make-demo-docs.mjs's marker/wording to read naturally
for a single break as well as several.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
make-demo-docs.mjs treated any '#'-prefixed line as a comment continuation,
which is right for Python/Ruby/Elixir but swallowed the '#define'/'#include'
lines immediately following the new vcpkg fixture's BREAKING comment into the
generated explanation text. Only treat '#' as a comment marker when it's
followed by whitespace or end of line, then regenerate all 16 DEMO.md files
against the current source.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Drift's Rust surface diff shells out to cargo public-api, which needs the
nightly toolchain to read rustdoc's unstable JSON output. Drift auto-installs
both itself on first analysis (tools.autoInstall defaults to true in the
extension), but cargo-public-api compiles from source, leaving the panel
apparently frozen for several minutes on a visitor's first open. Move that
wait into onCreateCommand instead, where a Codespace build is expected to
take a while.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Replace the README's <ecosystem>-parameterized URL with a generated table
where each demo has its own working https://codespaces.new link, built by a
new scripts/make-readme.mjs from the devcontainers that actually exist so it
can't drift. Also trims the README back to what a visitor needs: what the
repo is, how the demo state works, the table, and the maintenance scripts —
and states plainly that no demo has been smoke-tested in a real Codespace yet.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
browser-demo.md still described the pre-#19 upgrade.patch mechanism and
carried a hand-maintained, five-row Deep-links table left over from before
all 16 demos existed. Point both at what's actually there: demo.json's
find/replace edits, and the generated README table.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Add cheap, no-toolchain assertions: exactly 16 known ecosystems have a demo,
exactly 16 devcontainers exist, each demo.json declares at least one edit,
each demo's source carries at least one BREAKING marker, and the README
launch table is checked alongside the other generated files.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Copilot AI lite review requested due to automatic review settings August 29, 2026 19:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@RodolpheKouyoumdjian
RodolpheKouyoumdjian merged commit 99bf845 into main Sep 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants