feat: re-land markAsClicked on InboxAction and bump to 6.0.5 - #67
Merged
Conversation
The API landed in #65, but that PR targeted `master` — a branch ~10 commits behind `main` that the deploy workflow never publishes from. The change never reached npm, and the 5.6.18 bump it carried belonged to master's old version line. This puts the same code on `main` with a bump off 6.0.4. An action carries its own tracking id in `data.trackingId`, separate from the message's click tracking id, so a click can be attributed to the button the user actually pressed. `CourierInboxView` renders through the native SDKs, which report the click themselves, so nothing is added there — doing so would count each press twice. This is the API for apps that render their own action buttons. An action from a template that opted out of tracking arrives without an id and is a no-op. Also ships the Courier_iOS 5.8.6 podspec pin from #66, which merged after 6.0.4 was published and so has been sitting on `main` unreleased. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-lands the
InboxAction.markAsClickedAPI onmainand cuts the patch release that ships it.Why this exists
#65 merged into
master, notmain.mastersits ~10 commits behind the default branch anddeploy.ymlonly publishes onpush: branches: [main], so the API never reached npm —origin/mainstill had nomarkAsClicked. The version bump inside that PR was to5.6.18, master's stale version line;mainis on the 6.x line.This also carries the
Courier_iOS 5.8.6podspec pin from #66, which merged after 6.0.4 was published. That deploy run went green as a no-op (6.0.4 was already on npm), leaving the pin onmainunreleased. Bumping to 6.0.5 publishes both.Changes
InboxAction.markAsClicked(messageId)plus anInboxAction.trackingIdgetter, backed by the existingclient.inbox.click— identical to what feat: expose markAsClicked on InboxAction #65 put onmaster.inbox-action.test.tsx.package.json6.0.4 → 6.0.5.An action carries its own tracking id in
data.trackingId, separate from the message's click tracking id, so a click is attributed to the button the user actually pressed.CourierInboxViewrenders through the native SDKs, which report the click themselves — reporting again from JS would double-count every press. What was missing is only the API for apps that render their own action buttons. An action from a template that opted out of tracking arrives without an id and is a no-op.Verification
tsc --noEmitclean,eslintclean,jest131/131 passing (6 of them new).Follow-up
masteris stale and still accepts PRs — it is what caused this. Worth deleting or protecting so nothing else lands there.🤖 Generated with Claude Code