Update to heapless 0.9.1 and iso7816 0.2.0 - #30
Merged
Conversation
sosthene-nitrokey
marked this pull request as draft
August 20, 2025 15:26
sosthene-nitrokey
force-pushed
the
heapless-09
branch
from
October 3, 2025 15:45
fe95252 to
e61c8d9
Compare
sosthene-nitrokey
marked this pull request as ready for review
October 3, 2025 15:46
Comment on lines
+3
to
+4
| use heapless::VecView; | ||
| pub use iso7816::{command::CommandView, Interface, Status}; |
Member
There was a problem hiding this comment.
I think we should pub use both or none.
sosthene-nitrokey
force-pushed
the
heapless-09
branch
from
October 3, 2025 15:55
20f0257 to
696d8a7
Compare
robin-nitrokey
approved these changes
Oct 3, 2025
sosthene-nitrokey
force-pushed
the
heapless-09
branch
from
October 6, 2025 14:16
a9c4427 to
931c426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is where the view types come in handy.