Skip to content

Add bundle, bazel-bep, and constants to workspace members - #1154

Merged
trunk-io[bot] merged 1 commit into
mainfrom
add-implicit-workspace-members
Jul 30, 2026
Merged

Add bundle, bazel-bep, and constants to workspace members#1154
trunk-io[bot] merged 1 commit into
mainfrom
add-implicit-workspace-members

Conversation

@dfrankland

Copy link
Copy Markdown
Member

What

Adds bundle, bazel-bep, and constants to the root Cargo.toml's [workspace] members list.

Why

These three crates were already implicit workspace members — cargo automatically includes path dependencies that live inside the workspace directory and aren't in exclude — so this change is a no-op for cargo itself (Cargo.lock is unchanged).

However, external tooling that reads the root member list literally cannot see them. Specifically, trunk2 (rs/Cargo.toml) consumes six packages from this repo as a git dependency (bazel-bep, bundle, codeowners, constants, context, proto), and its Nix-based resolver (cargo-nix-plugin) resolves packages via the root workspace's member list rather than scanning the repo. It fails on the three unlisted crates:

error: resolveCargoWorkspace: package bazel-bep not found in git checkout <path>
       (https://github.com/trunk-io/analytics-cli#<rev>)

⚠️ Please keep these entries in members — an external consumer resolves this repo's packages through the root member list, so removing them again (e.g. while tidying the list) silently breaks trunk2's Nix build even though plain cargo keeps working.

rspec-trunk-flaky-tests/ is intentionally left as-is: it's a Ruby gem extension crate and not consumed by trunk2.

Verification

  • cargo metadata --no-deps succeeds from the repo root and from bundle/
  • cargo check --workspace --all-targets passes
  • Cargo.lock unchanged (no resolution/feature-unification changes)
  • taplo fmt clean

🤖 Generated with Claude Code

@trunk-io

trunk-io Bot commented Jul 30, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

These three crates were already implicit workspace members (cargo
auto-includes path dependencies inside the workspace directory), so
this is a no-op for cargo itself. But external tools that read the
root member list literally — notably the Nix-based resolver used to
build trunk2's Rust workspace, which consumes these packages as a git
dependency — cannot find non-listed packages. Listing them explicitly
fixes that resolution.

Co-Authored-By: Claude Fable 5 <[email protected]>
@dfrankland
dfrankland force-pushed the add-implicit-workspace-members branch from 308afc7 to 372fe8c Compare July 30, 2026 16:55
@trunk-staging-io

trunk-staging-io Bot commented Jul 30, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
pending_quarantine_test should be quarantined when run with variant A test marked as pending was expected to fail but unexpectedly passed. Logs ↗︎
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was actually 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎Docs

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.21%. Comparing base (7482566) to head (372fe8c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
+ Coverage   82.97%   83.21%   +0.24%     
==========================================
  Files          71       71              
  Lines       16044    16044              
==========================================
+ Hits        13312    13351      +39     
+ Misses       2732     2693      -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io

trunk-io Bot commented Jul 30, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io
trunk-io Bot merged commit da95686 into main Jul 30, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants