Repository navigation
feat(infra): rebuild the indexer with the testnet port open - #1457
Merged
Merged
Conversation
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@holdex pr submit-time 1h |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
The indexer's security group now allows TCP 8080 in the infra code, so a new stack, or a replaced group, keeps the port the testnet indexer serves on.
An indexer for testnet runs on the same host and serves its API on 8080 directly. That rule was added to the live group by hand, so the template does not have it.
What changes
NewIndexerInstanceadds a TCP 8080 ingress from anywhere to the indexer's security group, next to the HTTPS rule from the PR this follows.Deploying it
The live group already has this rule, and CloudFormation accepts a template rule that already exists by hand (I checked that on a throwaway stack for the HTTPS rule). If the deploy that first carries it fails and rolls back, the revoke can take the live 8080 rule with it. After a rolled-back deploy, check that the group still allows 8080 and add it back if it does not.
Tests
go test ./lib/kwil-indexer/passes in workspace mode, as the deploy workflows set it up. Changing the port in either rule makes the test fail.go run cdk_main.go, ascdk.jsonruns it) builds.