Skip to content

build(deps): claim withdrawals soon after their epoch closes - #1449

Merged
MicBun merged 1 commit into
mainfrom
bump-kwil-db-withdrawal-votes
Oct 19, 2026
Merged

MicBun merged 1 commit into
mainfrom
bump-kwil-db-withdrawal-votes

Conversation

@MicBun

@MicBun MicBun commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Description

The node pins kwil-db at 284bfd01. This moves the pin to 37e8fc04, the head of kwil-db main, which adds one pull request:

  • fix(bridge): claim withdrawals soon after their epoch closes kwil-db#1779: a validator's vote on a withdrawal epoch reads its nonce from the account for every vote, instead of from a count that only its own votes moved. The validator key also signs the market settlement transactions, so that count fell behind between withdrawals. On 19 Oct the mainnet validator's vote on an eth_usdc epoch was rejected as an invalid nonce for 80 minutes, and every later withdrawal waited behind it, until I restarted the validator.

Before the release

  • Executing a block gives the same results as before. The change is in the vote signer, which runs on a validator outside consensus and only picks the nonce of the vote transaction it broadcasts.
  • It adds no config key, migration or p2p protocol. kwil-db/core is the same at both commits, and its pin moves with kwil-db as before.
  • On mainnet only the leader votes, so the fix takes effect once the leader runs a release with this pin. Until then, restarting the leader clears a stuck vote.

Related Problem

How Has This Been Tested?

  • go build ./... and go vet -tags kwiltest ./... are clean with Go 1.25.3, the version CI and the Dockerfile use.
  • The go.mod diff is the two kwil-db lines, and go mod tidy changed nothing else.
  • The kwil-db pull request above passed kwil-db's CI, including its new test of the vote nonce.
  • I did not run the node's test packages locally. This pull request's CI runs them.

Summary by CodeRabbit

  • Maintenance
    • Updated underlying platform components to newer versions. No user-facing features are included in this update.

@MicBun MicBun self-assigned this Oct 19, 2026
@holdex

holdex Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Time Submission Status

Member # Time Running Total Status Last Update
MicBun 1h ✅ Submitted Oct 19, 2026, 1:20 PM

Submit or update total time with:

@holdex pr submit-time 2h

Add time on top of previous submission with:

@holdex pr add-time 1h30m

See available commands to help comply with our Guidelines.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9228124b-195e-4dd5-b89d-25facc4f410e
📥 Commits

Reviewing files that changed from the base of the PR and between 3336eed and 91b14b3.

⛔ Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing: 1
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The go.mod requirements for github.com/trufnetwork/kwil-db and github.com/trufnetwork/kwil-db/core were updated to pseudo-versions dated 2026-10-19.

Changes: Dependency version update

Layer / File(s) Summary
Update module requirements
go.mod
The required versions of kwil-db and kwil-db/core were updated from pseudo-versions dated 2026-10-12 to versions dated 2026-10-19.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 91b14

The dependency update includes the reported nonce fix, with no broken call contract identified. No material issue remains that should block merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the dependency update, which imports the withdrawal nonce fix that enables withdrawals soon after the epoch closes.
Linked Issues check Passed Issue #1448 is closed and supplies historical context only. No active directly linked issue remains. Therefore, this pull request has no applicable linked-issue coding requirements. The change is limi…
Out of Scope Changes check Passed The reviewed change updates only the kwil-db and kwil-db/core dependency pins in go.mod. The pull request description connects the pin to the historical signer nonce defect. No unrelated source, confi…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #1448 is closed and supplies historical context only. No active directly linked issue remains. Therefore, this pull request has no applicable linked-issue coding requirements. The change is limited to the reported kwil-db dependency pin update.

Full details: Out of Scope Changes check

Explanation

The reviewed change updates only the kwil-db and kwil-db/core dependency pins in go.mod. The pull request description connects the pin to the historical signer nonce defect. No unrelated source, configuration, migration, protocol, or test changes appear in the supplied whole-PR summary.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MicBun

MicBun commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

@holdex pr submit-time 1h

@MicBun
MicBun merged commit 793a8db into main Oct 19, 2026
11 checks passed
@MicBun
MicBun deleted the bump-kwil-db-withdrawal-votes branch October 19, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant