Repository navigation
ci: get slow integration test results back sooner - #1446
Conversation
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow now runs slow integration tests in three shards. Each shard selects its package list and runs it through the retry loop. If tests fail, the workflow prints the last 100 lines of the PostgreSQL container logs. ChangesSlow Integration Test Sharding
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The slow-test shards retain the previous package coverage. No actionable merge risk remains after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@holdex pr submit-time 1h |
Description
The slow integration tests ran as one job: every slow package in turn, about 135 minutes on a typical run. They now run as three jobs side by side:
order_booktests/streams/order_bookstreamstests/streamsrestrestis listed at run time withgo list, minus the two packages that have their own job, so a new test package lands there without editing the workflow. Together the three jobs cover the same 24 packages as before. A retry now reruns only its own job's packages, where a failure used to restart all of them.When a job's tests fail, the Docker diagnostics now also print the last lines of the test database container,
kwil-testing-postgres. A run that stalled on that container showed onlydocker ps, which said it was up and nothing more.The repository has no required status checks, so the new job names (
slow-integration-tests (order_book)and so on) need no settings change.Related Problem
Part of:
How Has This Been Tested?
run-slow-testslabel the workflow mentions does not exist in this repository. I started the workflow by hand on this branch instead, which runs all three jobs. All three passed:order_bookin 41 minutes,streamsin 43 andrestin 50, so the whole run took 50 minutes:Summary by CodeRabbit