Repository navigation
fix: set tempo synced lfo rate directly via smoother instead of apvts… - #8
Merged
Merged
Conversation
trsctr
added a commit
that referenced
this pull request
May 18, 2026
* 0.2.0-beta.1: Filter modulation (#5) * add filterengine and stereofilter classes * update cmakelists, wire filterengine to delayengine, create types.h for channel enum * add parameters for filter modulation * add mod param update to filterengine, smoothen cutoff with onepolelp, rename params * switch to octave based filter modulation, fix lfo phase bug * add lfoscope component + buffer for debug purposes, add it to editor only present in debug build * finetune filter mod range and value display * add square to lfo shapes * flip lfo phase for high cut * clean up old code from delay engine * add tempo lfo tempo sync + parameters * add size options and custom look and feel for small rotary knob * add filter mod depth controls to gui * display phase in degrees * add saw up/down shapes to lfo * add parameter for highcut mod invert toggle * add params for setting filter lfo shape * sync tempo synced lfo to song position * add sample & hold modulation * redefine lfo tempo sync note values, set max mod rate to 8hz * set max filter q to 1.5 * update changelog * add selector component and lfo waveform gui selector element * fix tempo sync bug in s&h lfo * add lfo value indicators to filter mod section * add high cut lfo invert toggle to gui * move delay mode selector label to left side of menu * update changelog, readme, cmakelists version number * code cleanup * fix version number string in cmakelists, hardcode beta version number to editor * remove unused variables from Parameters.h * fix: harden CI/CD pipeline security (#7) - Pin third-party actions to commit SHAs - Upgrade softprops/action-gh-release to v3 - Pin pluginval to v1.0.4 with SHA256 checksum verification - Run pluginval on a copy of the binary to prevent tampering with build artifacts * fix: set tempo synced lfo rate directly via smoother instead of apvts param (#8) * chore: update docs for release 0.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write synced LFO Hz directly to the rate smoother instead of through the APVTS parameter, which clamped values to 8 Hz at higher BPMs