Skip to content

Upgrade otelgrpc to v0.70.0 and add --drop_metrics flag - #917

Merged
phbnf merged 1 commit into
transparency-dev:mainfrom
phbnf:otelmetrics
Aug 12, 2026
Merged

Upgrade otelgrpc to v0.70.0 and add --drop_metrics flag#917
phbnf merged 1 commit into
transparency-dev:mainfrom
phbnf:otelmetrics

Conversation

@phbnf

@phbnf phbnf commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Towards #918.

  • Upgrades go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.70.0 (and associated OpenTelemetry SDK packages to v1.45.0) to ensure dial target hostnames are preferred over resolved peer IPs, preventing cardinality growth on client metrics. This should fix Unexpected metric export increase #918.
  • Adds the --drop_rpc_metrics flag (default: false) to allow dropping rpc.client.* metrics via an OpenTelemetry View if needed.

@roger2hk

Copy link
Copy Markdown
Contributor

How about creating --drop_metrics flag that accepts the prefix of the dropped metrics (e.g. rpc.client.*)? This helps when someone wants to drop something else.

@phbnf
phbnf requested a review from roger2hk August 12, 2026 10:29
- Upgrades go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  to v0.70.0 (and associated OpenTelemetry SDK packages to v1.45.0) to ensure
  dial target hostnames are preferred over resolved peer IPs, preventing
  cardinality growth on client metrics.
- Adds the --drop_metrics flag (default: "") to allow dropping specific
  metric name patterns via OpenTelemetry Views if needed.
@phbnf
phbnf marked this pull request as ready for review August 12, 2026 10:38
@phbnf
phbnf requested a review from a team as a code owner August 12, 2026 10:38
@phbnf

phbnf commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

Good point, done!

@phbnf
phbnf requested a review from mhutchinson August 12, 2026 11:20
@roger2hk roger2hk changed the title Upgrade otelgrpc to v0.70.0 and add --drop_rpc_metrics flag Upgrade otelgrpc to v0.70.0 and add --drop_metrics flag Aug 12, 2026
@phbnf
phbnf merged commit 9e3aa47 into transparency-dev:main Aug 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected metric export increase

3 participants