Repository navigation
test(physics): build physics_dyn_bike_plant_test without FP contraction - #837
Merged
Merged
Conversation
StepsAsTheDynamicPlantDoes compares dyn_bike_plant's steps with dyn_plant called inline in the test, bit for bit. The plant is built with -ffp-contract=off (the exact-fp list); the test was not, so on the macOS arm64 lanes clang fused its copy into FMAs and the two differed by one ulp (package-macos / libcvc-release on #833: 0.40661397752110373 vs ...368 at tick 4). Build the test the same way, as nav_potential_test and nav_material_ext_test already are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynBikePlant.StepsAsTheDynamicPlantDoes(from #833) holdsdyn_bike_planttodyn_plantcalled inline in the test, bit for bit. The plant's source is in the exact-fp list (-ffp-contract=off); the test's was not, so on the macOS arm64 lanes clang fused the test's copy into FMAs and they differed by one ulp:(
package-macos / libcvc-releaseon #833, master eb9187c.)This builds the test the same way, as
nav_potential_testandnav_material_ext_testalready are (/fp:preciseon MSVC). The assertion stays exact.It lands before the
v3.7.1tag, so the release's macOS packages don't trip on it.