Repository navigation
ci: run the Windows suite without MAGICK_* variables - #810
Merged
Merged
Conversation
The package-windows test step pointed MAGICK_CODER_MODULE_PATH, MAGICK_FILTER_MODULE_PATH and MAGICK_CONFIGURE_PATH at the deps prefix for every test. Since #673 and #774 libcvc finds the extracted cvcpkg ImageMagick's coders and config itself, so the variables only hid that lookup from every test but magick_bootstrap_test. Without them the whole suite, ImageTest and the CvcCliTest vol2img/img2vol cases included, runs as a local build does. The recipe/windows-2022 job never set them: on #774 it passed all 4389 tests, ImageTest.* and MagickBootstrapTest.* among them. The removed block's debug\bin branch was dead, since the Windows matrix is Release only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #774.
package-windows's Run tests step pointedMAGICK_CODER_MODULE_PATH,MAGICK_FILTER_MODULE_PATHandMAGICK_CONFIGURE_PATHat the deps prefix for the whole ctest run. Since #673 and #774, libcvc finds the extracted cvcpkg ImageMagick's coders and config by itself (set_magick_paths_wininsrc/cvc/image/magick_io.cpp). Setting the variables only hid that lookup from every test exceptmagick_bootstrap_test, which removes them itself.This PR removes the block and leaves a comment explaining why the variables are absent. The whole Windows suite then runs the way a local build does, including
ImageTest.*and theCvcCliTestvol2img/img2vol cases, whosecvc.exechild processes inherit the environment.Why this should be green
recipe / windows-2022 / Releasenever set these variables (its log has noMAGICK_at all). On image: find ImageMagick's coders beside a build tree on Windows; test with no MAGICK_* set #774 it passed all 4389 tests, including all 28ImageTest.*and all 4MagickBootstrapTest.*cases.image_test,cvc_cli_test(Vol2ImgExportsSlices,Img2VolImportsSlices) andmagick_bootstrap_testwith noMAGICK_*set, in four Windows layouts. All passed, and ctest passed 34/34.cvc::init_imagemagick().src/cvc/imageandvolume_ops.cppare the only users; the mesher hits areVolMagick::.debug\binbranch never ran, because the Windows matrix is Release only (there are no windows-debug dep bundles).$isDebugstays, since the PATH setup above still uses it.Checked locally
ci.ymlstill parses as YAML.${{ … }}expressions substituted, parses with 0 errors, the same as on master.