Repository navigation
state_exec test: tighter stack for the native-nesting stack check (macOS) - #687
Merged
Merged
Conversation
… on macOS ApplyOnASelfContainingList expected the stack, not the 256-level count, to stop (apply apply L) on a stack 64 KiB above the reserve. An apply level is about 0.5 KiB with MSVC but under 0.25 KiB with Apple clang, so on macOS all 256 levels fit and recipe / macos-latest / Release failed after #683. The check now runs 16 KiB above the reserve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix for a failure #683 left on master:
recipe / macos-latest / ReleasefailsStateExecNativeNesting.ApplyOnASelfContainingListwithexpect_nesting_limit(loop) < kMaxNativeNesting, actual 256 vs 256.The test checks that on a small stack the stack check (
kNativeStackReserve), not the 256-level count, stops(apply apply L)withLcontaining itself. The small stack had 64 KiB of room above the reserve. Anapplylevel is about 0.5 KiB with MSVC, but under 0.25 KiB with Apple clang, so on macOS all 256 levels fit and the count stopped it first. The library behaved correctly; the test's stack was too generous.The check now runs on a stack only 16 KiB above the reserve; the 4 MiB check that the level count stops it is unchanged. Locally (MSVC Release)
state_exec_deep_data_testpasses, 30/30, three runs. macOS is checked by this PR's CI.