Repository navigation
ariadne_runtime_test: a predicate cut by the time cap passes however it is reported - #680
Merged
Merged
Conversation
…it is reported PredicateMaterializerIsCutByTheEvalBudget (from #665) runs a one-node-a-step collections.range 120000 in a predicate and expects it cut. On the Linux Debug lane the time cap fired inside the job's own deadline poll, which reports "collections.range: evaluation exceeded time budget" through the job's error rather than the evaluator's "exceeded the eval budget" (seen on #678, job 117587719214). Both are the predicate being cut; the test now accepts either.
transfix
enabled auto-merge (squash)
October 18, 2026 05:18
transfix
added a commit
that referenced
this pull request
Oct 18, 2026
…p-finish Conflicts: STATE_EXEC_GRAMMAR.md's native-calls list (state-json/state-from-json from #681, state-set here: both kept), and the tests #681/#682 and this branch each added to state_exec_data_steps_test.cpp and state_exec_deep_data_test.cpp (all kept). #675's pycvc tests asserted the old parser.max_depth default of 256; they now compare with pycvc.parse_options().max_depth, as agreed with the parity session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AriadneStdlib.PredicateMaterializerIsCutByTheEvalBudget(added in #665) failed on the Linux Debug lane for #678 (job 117587719214). The failure is in the test's timing, not in #678.The test runs
(> (length (collections.range 120000)) 0)as a predicate withdata.step_nodes= 1 and expects the predicate's budget to cut it. On a slow Debug build the time cap fires first. Inside thecollections.rangejob, the job's own deadline check sees it before the evaluator's between-steps check does, so the warning readsfailed at eval (collections.range: evaluation exceeded time budget)instead ofexceeded the eval budget.Both messages mean the predicate was cut, so the test now accepts either. Nothing outside the test changes.
Verified locally (MSVC Release):
ariadne_runtime_test133/133; theAriadneStdlibtests passed 20 repeat runs; clang-format clean.