[transfix]

Full SWIG wrap: DCContext managers, EisPyContext, listener directors

Overview

Complete Python SWIG bindings for libeiskaltdcpp — 4 phases of modular .i file wrapping, class renaming, listener directors, and end-to-end integration testing against a live NMDC hub.

Phase 1: Modular SWIG manager wrapping (1f28d58)

• 17 modular .i files wrapping all dcpp managers via DCContext typed accessors
• dcpp_types.i for CID, TTHValue, UserPtr, HintedUser, etc.
• dcpp_context.i with typed manager properties (settings_manager, queue_manager, etc.)
• eispy_context.i with %extend shortcuts for EisPyContext
• 108 tests in test_swig_managers.py

Phase 2: SettingsManager + FavoriteManager enums (af200af)

• Full enum wrapping for all SettingsManager int/string/bool/int64 settings
• FavoriteManager SWIG wrapping with HubEntry class
• 503 tests covering all settings enums and manager access

Phase 3: Remove DCBridge → EisPyContext (f54d288)

• Renamed DCBridge → EisPyContext across all C++/SWIG/Python code
• Removed bridge.h / bridge.cpp (replaced by eispy_context.h/.cpp)
• DCBridge = EisPyContext Python alias for backward compatibility
• Migrated DCClient.py to use direct manager calls
• 181 tests passing (50 dc_core + 108 swig_managers + 23 others)

Phase 4: Full listener directors (2cf8343)

• 7 Python-subclassable listener adapter classes in listener_adapters.h:
  • PyClientListener — 15 per-hub events (connect, chat, users)
  • PyClientManagerListener — 7 global user/hub lifecycle events (NEW)
  • PySearchManagerListener — search result events
  • PyQueueManagerListener — all 18 queue events
  • PyDownloadManagerListener — 5 download transfer events
  • PyUploadManagerListener — 6 upload transfer events
  • PyTimerManagerListener — second/minute tick events
• Adapters convert dcpp tag-dispatched on() to named virtual methods
• Pass Python-safe types (strings, ints, types.h structs) — no raw C++ pointers
• SWIG directors + threads="1" handle GIL automatically
• 14 subscribe/unsubscribe methods on EisPyContext
• BridgeListeners default multiplexer unchanged
• 89 new tests in test_swig_listeners.py

Phase 5: Integration testing & ABI fix

End-to-end integration tests against a live NMDC hub (nmdcs://wintermute.sublevels.net:411), exercising the full stack from Python through SWIG directors into the C++ core and back.

Integration test suite (test_integration.py, test_file_transfer.py)

• 16 integration tests covering hub connect/disconnect, user enumeration, chat, search, and peer-to-peer file transfer
• Two independent EisPyContext instances (alice + bob) connecting to a real hub simultaneously
• File transfer test: bob (passive, INCOMING_FIREWALL_PASSIVE) requests alice's (active) file list via $RevConnectToMe → $ConnectToMe → TLS peer connection
• Custom DCClientCallback subclass with async event capture via asyncio.Event

ABI mismatch fix: LUA_SCRIPT propagation (5bf4d28)

• Root cause: dcpp::Client conditionally inherits ClientScriptInstance when LUA_SCRIPT is defined, adding an 8-byte vtable pointer that shifts all member offsets. The bridge library's target_compile_definitions used PRIVATE visibility, so the SWIG dc_core module compiled Client.h without the define — ABI mismatch between the dcpp shared library and the SWIG wrapper.
• Symptom: hubUrl.size() returned 0x55A4E7E34DF0 (~85 TB) because the _M_string_length field was read at offset−8, landing on the _M_dataplus._M_p (heap pointer) field instead. The subsequent string copy attempted to allocate ~85 TB → std::bad_alloc.
• Fix: Changed PRIVATE → PUBLIC for target_compile_definitions(eiskaltdcpp_py_bridge ... LUA_SCRIPT) and both target_include_directories calls in the if(EISKALTDCPP_HAS_LUA) block. CMake's transitive property system now propagates -DLUA_SCRIPT and the Lua/stub include paths to all consumers of the bridge library, including the SWIG module.

Upstream eiskaltdcpp fixes (pinned at c9940e1e)

• Comprehensive noexcept removal — 414 incorrect noexcept specifiers removed across 61 dcpp files; exceptions now propagate instead of calling std::terminate
• Speaker::fire() exception safety — try/catch around listener dispatch
• Thread stack reduction — pthread_create with 1 MiB stacks on POSIX (down from 8 MiB default), reducing virtual memory from ~500 MB to ~100 MB on busy hubs
• ConnectionManager leak fix — nmdcConnect()/adcConnect() catch all exceptions from connect(), properly cleaning up UserConnection objects
• noexcept removal in bridge — all listener on() overrides in bridge_listeners.h and listener_adapters.h had noexcept removed to match upstream

Test coverage

• 732 tests across 16 test files
• 924 pytest tests passing in CI (including parameterized variants)
• 16 integration tests against live NMDC hub
• All 8 CI build jobs green (Ubuntu, self-hosted Linux, Windows MSVC, Windows MinGW, macOS)
• All adapter classes instantiable from Python
• Python subclassing with method override verified
• Director identity and multiple instance tests

CI/CD pipeline

• 8 parallel build jobs: Ubuntu 24.04, self-hosted Linux x64, Windows MSVC, Windows MinGW (UCRT64), macOS 14 (ARM64), macOS 13 (x86_64), plus dedicated pytest and integration test jobs
• Integration tests run on self-hosted runner with real network access to NMDC hub
• FetchContent pins eiskaltdcpp at a specific commit SHA for reproducible builds
• Cross-platform: Linux, Windows (MSVC + MinGW), macOS (ARM + x86_64)

Usage example

import dc_core

class MyQueueListener(dc_core.PyQueueManagerListener):
    def onAdded(self, target, size, tth):
        print(f"Queued: {target} ({size} bytes)")
    def onFinished(self, target, size, dir):
        print(f"Done: {target}")

ctx = dc_core.EisPyContext()
ctx.initialize('/tmp/dc-config')
listener = MyQueueListener()
ctx.addQueueListener(listener)