Repository navigation
Local/World transform space, rotate about assigned axis, and Shape List row context menu - #266
Merged
Merged
Conversation
added 3 commits
September 16, 2026 17:19
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2cf74f3. Configure here.
| return; | ||
|
|
||
| // Drop the world-space mouse anchor; update_rotate_from_world_ recaptures so the angle stays. | ||
| clear_all(m_initial_mouse_pos, m_rotate_pln, m_captured_axis_dir); |
There was a problem hiding this comment.
Space switch drops captured view axis
Medium Severity
A mid-drag Local/World switch clears m_captured_axis_dir and m_rotate_pln for every rotate mode, including View-to-object. That axis does not depend on transform space, so after an orbit the preview immediately reapplies the kept angle around the live camera direction instead of the frozen first-sample axis.
Reviewed by Cursor Bugbot for commit 2cf74f3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
gui.transform_space.gui_shp_pane.cpp; row drawing isgui_shp_detail::Shape_list_row_drawerinstead of a recursive lambda ingui.cpp.Test plan
EzyCadandEzyCad_testsEzyCad_testsfilters coveringTransform_axes,Transform_translation,Rotate_axis,Set_framedocs/usage.mdMove/Rotate/Scale + Shape List,usage-settings.mdtransform_space, CHANGELOGNotes
Note
Medium Risk
Changes interactive transform math and pivot behavior for core modeling tools; incorrect rebasing or axis capture could mis-apply geometry until undo.
Overview
Adds Local vs World transform space for Move, Rotate, and Scale (Options + persisted
gui.transform_space). Local uses the first selected solid’s assigned frame; World uses global XYZ at that solid’s bbox center. Shared logic lives inshp_transform, and move/rotate/scale pivots and constrained axes follow the chosen space.Rotate is reworked: X/Y/Z and view-to-object can be set before the first drag; the drag plane and view-to-object axis are frozen on the first sample so orbit/pan does not retarget the gesture; constrained axes rotate about the assigned frame axis with a perpendicular plane when the view faces the axis; switching Local/World mid-drag re-baselines the mouse anchor while keeping the current angle. Scale similarly re-baselines mid-drag so the factor does not jump.
The Shape List moves to
gui_shp_pane.cpp(Shape_list_row_drawer); right-click opens the row context menu anywhere on the row (not only name/M). Docs, default settings, scripting JSON, and tests cover transform space and the new rotate/scale behavior.Reviewed by Cursor Bugbot for commit 2cf74f3. Bugbot is set up for automated code reviews on this repo. Configure here.