Skip to content

PM-6247: Hide Iterative Review from Task timelines #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 1 commit into from
Sep 11, 2026
+106 −13
Merged

PM-6247: Hide Iterative Review from Task timelines #2281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 101 additions & 7 deletions src/apps/opportunities/src/components/ChallengeDetailHeader.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,22 +672,116 @@ describe('ChallengeDetailHeader actions and presentation', () => {
})
})

it('retains a future Iterative Review deadline in a Task timeline', () => {
it.each([
{
challengeEnd: '2026-08-31T17:44:00.000Z',
challengeStart: '2026-08-10T17:44:00.000Z',
isOpen: true,
phaseEnd: '2026-08-15T17:44:00.000Z',
phaseStart: '2026-08-13T17:44:00.000Z',
state: 'current',
},
{
challengeEnd: '2999-08-31T17:44:00.000Z',
challengeStart: '2999-08-10T17:44:00.000Z',
isOpen: false,
phaseEnd: '2999-08-21T17:44:00.000Z',
phaseStart: '2999-08-20T17:44:00.000Z',
state: 'future',
},
])('omits a $state Iterative Review phase from a Task timeline', ({
challengeEnd,
challengeStart,
isOpen,
phaseEnd,
phaseStart,
}: {
challengeEnd: string
challengeStart: string
isOpen: boolean
phaseEnd: string
phaseStart: string
}) => {
const { container }: RenderResult = render(
<MemoryRouter>
<ChallengeDetailHeader
busy={false}
challenge={challengeFixture({
currentPhase: isOpen ? {
isOpen: true,
name: 'Iterative Review',
scheduledEndDate: phaseEnd,
} : undefined,
currentPhaseNames: isOpen ? ['Iterative Review'] : [],
endDate: challengeEnd,
phases: [
{
actualEndDate: challengeEnd,
actualStartDate: challengeStart,
id: 'registration',
name: 'Registration',
},
{
id: 'iterative-review',
isOpen,
name: 'Iterative Review',
scheduledEndDate: phaseEnd,
scheduledStartDate: phaseStart,
},
{
actualEndDate: challengeEnd,
actualStartDate: challengeStart,
id: 'submission',
name: 'Submission',
},
],
startDate: challengeStart,
type: { name: 'Task' },
})}
isRegistered={false}
onRegister={jest.fn()}
onSubmit={jest.fn()}
onUnregister={jest.fn()}
/>
</MemoryRouter>,
)

fireEvent.click(screen.getByRole('button', { name: 'Show full timeline' }))
const timeline = screen.getByRole('region', { name: 'Challenge timeline' })
const itemLabels = within(timeline)
.getAllByRole('listitem')
.map(item => item.querySelector('strong')?.textContent)
expect(itemLabels)
.toEqual(['Launch', 'Registration', 'Submission', 'Winners'])
expect(within(timeline)
.queryByText('Iterative Review'))
.not.toBeInTheDocument()
expect(container.querySelector('.timelineItems'))
.toHaveStyle({
gridTemplateColumns: '88px minmax(0, 1fr) minmax(0, 1fr) 88px',
})
})

it('retains Iterative Review for non-Task challenge timelines', () => {
render(
<MemoryRouter>
<ChallengeDetailHeader
busy={false}
challenge={challengeFixture({
currentPhase: undefined,
currentPhaseNames: [],
endDate: '2999-08-21T17:44:00.000Z',
currentPhase: {
isOpen: true,
name: 'Iterative Review',
scheduledEndDate: '2026-08-15T17:44:00.000Z',
},
currentPhaseNames: ['Iterative Review'],
phases: [{
actualEndDate: '2999-08-21T17:44:00.000Z',
actualStartDate: '2999-08-20T17:44:00.000Z',
id: 'iterative-review',
isOpen: true,
name: 'Iterative Review',
scheduledEndDate: '2026-08-15T17:44:00.000Z',
scheduledStartDate: '2026-08-13T17:44:00.000Z',
}],
type: { name: 'Task' },
type: { name: 'Challenge' },
})}
isRegistered={false}
onRegister={jest.fn()}
Expand Down
11 changes: 5 additions & 6 deletions src/apps/opportunities/src/components/ChallengeDetailHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ function challengeTimelineEnd(challenge: ChallengeOpportunity): string | undefin
/**
* Builds the Figma timeline sequence from Challenge API boundaries and phases.
* Authored phases stay chronological, with Registration first when valid starts match.
* Task timelines omit Iterative Review because that phase is not member-facing for Tasks.
*
* @param challenge Challenge API detail response.
* @param selected API-authoritative current phase.
Expand All @@ -314,12 +315,10 @@ function challengeTimelineItems(
const endDate = challengeTimelineEnd(challenge)
const endTimestamp = timelineTimestamp(endDate)
const taskChallenge = isTaskChallenge(challenge)
const authoredPhases = (challenge.phases ?? []).filter(item => {
const phaseKey = challengeCatalogKey(item.name)
if (!taskChallenge || !phaseKey.includes('iterativereview')) return true
const phaseEnd = timelineTimestamp(item.actualEndDate ?? item.scheduledEndDate)
return phaseEnd !== undefined && phaseEnd > now
})
const authoredPhases = (challenge.phases ?? []).filter(item => (
!taskChallenge || !challengeCatalogKey(item.name)
.includes('iterativereview')
))
const phases = authoredPhases
.map((item, index) => ({ index, item }))
.sort((left: IndexedChallengePhase, right: IndexedChallengePhase) => {
Expand Down
Loading