Repository navigation
Add configurable physical-key input-source bindings - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
After: Checks pass for intrinsic Fn flags, physical Fn shortcuts, fresh presses after missed releases, and event-tap recovery.
After: Native AppKit smoke checks covered five bindings, recording, duplicate rejection, Apply/Cancel, reset, unavailable sources, and persistence after restart.
After: Assigned A and its repeats insert no text. Command-A still selects all, and normal C replaces the selection.
make testandmake lintpassed.swift build --build-system nativepassed. The default backend failed withUnknown error parsing property listin this environment.make app -o build BIN=.build/debug/2cmdandcodesign --verify --strict dist/2cmd.apppassed.Merge Danger
Door: one-way
Migration removes legacy preference keys after saving the ordered bindings. An older binary cannot read the new bindings. Rollback requires restoring legacy preferences.
Blast Radius: keyboard
Assigned ordinary keys suppress their normal actions globally while enabled. Fn/Globe, Caps Lock, Shift, and multimedia keys cannot be assigned. Event-pairing regressions could affect typing or shortcuts.