Repository navigation
feat(lnd): expose direct wallet transaction lookup - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
LndApi::get_transaction(&str)usingWalletKit.GetTransactionso callers can retrieve one wallet transaction by txid instead of scanning wallet history.fedimint-tonic-lndto immutable commit86fde7f1928d06ec57d843e919e7b62b2858df70from chore: sync upstream LND RPC definitions tonic_lnd#2.lnrpc::Transaction, including wallet-owned output details and unconfirmed transactions.UNIMPLEMENTEDasError::NodeApiUnsupported; retain existing error handling for other statuses. No error-text matching, retry or wallet-history fallback.Dependency / rollout
Depends on tonic_lnd PR #2. This is intended for https://github.com/The-Bitcoin-Company/tbc-rust/pull/652. Requires LND >= 0.18 with WalletKit and
onchain:readpermission. Callers retain responsibility for their RPC timeout.Validation
Using the TBC Rust Nix development shell:
-D warningspassed.