Repository navigation
Specialize BytesMut::extend<u8> when its Vec-backed - #829
Merged
Merged
Conversation
AdamGS
changed the title
BytesMut::extend<u8> when its Vec-backed
AdamGS
force-pushed
the
adamg/specialize-extended-vec
branch
from
June 15, 2026 19:04
02decdb to
dc47673
Compare
Contributor
Author
|
Messed up an unsafe block, now fixed |
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
AdamGS
force-pushed
the
adamg/specialize-extended-vec
branch
from
September 16, 2026 11:13
444fb1b to
8884ead
Compare
Contributor
Author
|
I've made another pass at this PR to simplify it. Its mush smaller and simpler now while still having the same performance. |
|
This seems reasonable to me and would be a nice improvement. I would also appreciate it if it were merged. |
GlenDC
reviewed
Nov 9, 2026
Contributor
Author
|
thanks for the review @GlenDC! I've addressed both comments. |
Member
|
lgtm now, thanks! |
GlenDC
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a specialized code path to extending
BytesMutwhen its backed by aVec. There are no external changes, only a private function and type with some tests.When benchmarking on my laptop (M3 Max MacBook Pro), the change to
put_slice_vec_extendis from 480 MB/s to over 9000MB/s. Happy to bench on some Intel hardware if the data is interesting.