fix: keep the working spinner in the editor border - #11
Merged
Merged
Conversation
VinhLe1410
marked this pull request as ready for review
September 9, 2026 07:49
Owner
|
Cheers and sorry this took so long! |
Contributor
Author
|
@tmustier yippie, glad for you merging it :)) don't mind the wait, I love the UX this extension provides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi now puts the working spinner in the default editor border. Queue-steer creates a custom editor without opting in, so the spinner appears above the input instead.
Set
embedWorkingStatus: trueon the fallback editor. Leave previously installed custom editors unchanged.Validation:
npm run check, 10 existing tests fromtest/editor-render.test.tsandtest/pi-integration.test.ts, andgit diff --checkpassed. Visual verification remains pending because tmux is unavailable.Note: I'm not sure if this fits your styles or not, but I think this is worth looking at. See screenshot below: