Repository navigation
chore: replace ts-node with tsx, update dependencies, move to ESLint 10 - #13
Merged
Merged
Conversation
…nt 10 Tooling - ts-node (unmaintained; source of the --experimental-loader and DEP0180 warnings) is replaced by tsx for mocha and bin/dev. - ESLint 10 with eslint-config-oclif 7 (flat config, typescript-eslint 8) replaces the config that warned on TypeScript 5.4+. Ordering, spacing and newer stylistic/type-safety rules the old config never had are off. - TypeScript 6; tsconfigs now list their types explicitly. Dependencies - Updated: mocha 12, chai 6, ESLint 10, moment-timezone 0.6, cheerio, axios, impit, domhandler 6, tsx. Production dependencies audit clean. - @oclif/* stays on the current majors; the next ones need Node 22 and the project policy makes raising the floor a major release. - Removed unused packages: node-persist, json2csv, node-localstorage, shx, @oclif/plugin-plugins (bundled npm itself and was never loaded) and the matching @types. The build clears dist/ with Node. - Lockfiles regenerated from a clean tree against the public registry: all platforms' optional packages are present (npm ci failed in CI without them) and the internal packages.atlassian.com URLs are gone. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9Y5xJdDbjzZFbNfVFKS5b
tmack8001
force-pushed
the
chore/modernize-toolchain
branch
from
October 22, 2026 15:46
4ecd9f8 to
93ba01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Clears the deprecation warnings from
yarn testandyarn lint, then audits and updates the dependency tree.--experimental-loaderand[DEP0180] fs.Stats constructorcome fromts-node, which is unmaintained. Replaced withtsx.eslint-config-oclif-typescript@3(typescript-eslint 6, TS < 5.4; the package is no longer supported on npm). Moved to ESLint 10 witheslint-config-oclif@7(typescript-eslint 8, flat config). ESLint 9 itself is now flagged unsupported by npm.Type of Change
Changes Made
Tooling
.mocharc.json:import=tsxinstead of thets-nodeloader and require;bin/dev.js/bin/dev.cmdrun throughtsx;ts-nodeblock removed fromtsconfig.json.eslint.config.mjsreplaces.eslintrc.json/.eslintignore;lintiseslint .. Rules that would reshuffle code (switch cases, object keys, union members, spacing) and the newer stylistic / type-safety packs the old config never had are off, each with a comment. Findings that remain are 0 errors and 19 warnings (jsdoc, complexity, nested callbacks).typesexplicitly, since TS 6 stops auto-including@types/*.test/tsconfig.jsonnow actually includes the test files (it inheritedinclude: src), so linting can parse them.node:prefixes inexamples/,=== -1index checks,String.raw, a namespace cheerio import andElementfromdomhandlerin a test helper, one disable for a type-positionResponse.Dependencies
@oclif/core4,@oclif/plugin-help6,@oclif/test4,oclif4: the next majors require Node 22, anddocs/RELEASING.mdtreats raising the floor to 22 as a major release.node-persist,json2csv,node-localstorage,shx,@oclif/plugin-plugins(bundled the wholenpmCLI and is not inoclif.plugins), and the matching@types/*. The build andpostpackclear files with Node.docs/ARCHITECTURE.mdno longer claimsnode-persistcaching, which the code never did.npm audit: production dependencies 0 vulnerabilities. Dev-only findings remain (9: 4 high, 5 low) from thebraceschain underoclif4 (no patchedbracesexists) and a lowkatexchain undereslint-config-oclif7. Neither runs in the published CLI.[email protected]is reported deprecated by npm; it comes fromcheerio1.2 viaencoding-sniffer, upstream.Lockfiles
package-lock.jsonandyarn.lockregenerated from a clean tree against the public registry. This removes ~490resolvedURLs that pointed at an internalpackages.atlassian.commirror (which madenpm cihang outside that network). The first push of this PR failednpm ciin CI because the lockfile was generated from a partly-installed tree and lacked other platforms' optional packages; fixed by regenerating with nonode_modulespresent.Platform(s) Affected
(Tooling and dependencies only; no parser or CLI behaviour changes.)
Testing
npm test): 557 passing, no ts-node warningstsc -bandtsc -p test/tsconfig.jsonclean;eslint .0 errorsnpm cifrom the regenerated lockfile;npm run smoke:installpasses;node bin/run.js --helpworks without@oclif/plugin-pluginsyarn install --frozen-lockfileacceptsyarn.lock(with--ignore-engines, see notes)Not run: CI on the new head,
bin/dev.jsthroughtsxend to end.Checklist
Documentation
docs/folderAdditional Notes
jsdoc-type-pratt-parser) wants 22.22.2+, whichyarn installenforces (npmonly warns). The published CLI'senginesis unchanged (>=20.18.1).@types/node(kept at^20to matchengines) and TypeScript 7 (typescript-eslint supports < 6.1).🤖 Generated with Claude Code
https://claude.ai/code/session_01W9Y5xJdDbjzZFbNfVFKS5b