Repository navigation
fix: refuse system column names for user columns (4.0.3) - #17
Merged
Merged
Conversation
`create table t (xmin text)` is rejected by postgres ("column name "xmin"
conflicts with a system column name") and was accepted here. Covers
CREATE TABLE, ADD COLUMN and RENAME COLUMN. Found by rapidnative-website's
converter tests, which use it as SQL postgres must reject.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create table t (xmin text)is rejected by Postgres (42701 column name "xmin" conflicts with a system column name) and pg-mem accepted it. Now refused fortableoid,xmin,cmin,xmax,cmax,ctidin CREATE TABLE, ADD COLUMN and RENAME COLUMN. A differently-cased quoted name ("Xmin") or a query alias is still fine, as in Postgres.Found by rapidnative-website's
test:ts-schemaandtest:nativewind-migration, which use exactly this as "SQL Postgres rejects" to check the converter aborts (RapidNative/rapidnative-website#2449 CI).Checks:
bun test: 1346 pass, 0 fail (new case incorpus-parity.spec.ts)test:agentneeds Supabase env locally, fails the same on main)Version 4.0.3.
🤖 Generated with Claude Code