fix(session): an anonymous request stores no session - #200
Merged
tina4stack merged 1 commit intoOct 5, 2026
Merged
tina4stack merged 1 commit into
tina4stack merged 1 commit into
Conversation
Every request, including static files, 404s and health checks, stored a session or set a session cookie even when nothing was ever put in it, so session storage grew with anonymous traffic. A session that was never stored and holds no data of its own is no longer written and gets no cookie. That also covers a request that only marked the session changed without leaving anything in it (deleting a key it never had, clear(), regenerate() on an empty session): a record with no data is not a session. A request that stores a value, or that arrived with a session cookie for a stored session, behaves as before, and clearing a stored session still ends it. python: Session.is_fresh() looks at the raw data, so a session holding only SSO pending state is not fresh. The cookie decision is _session_needs_cookie(). Signed-off-by: Michael <[email protected]>
Contributor
Author
|
I have read the Tina4 Contributor Licence Agreement and I agree to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every request, including static files, 404s and health checks, stored a session or set a session cookie even when nothing was ever put in it, so session storage grew with anonymous traffic.
Change. A session that was never stored and holds no data of its own is no longer written and gets no cookie. That also covers a request that only marked the session changed without leaving anything in it (deleting a key it never had,
clear(),regenerate()on an empty session): a record with no data is not a session. A request that stores a value, or that arrived with a session cookie for a stored session, behaves as before, and clearing a stored session still ends it.python:
Session.is_fresh()looks at the raw data, so a session holding only SSO pending state is not fresh. The cookie decision is_session_needs_cookie().Tests.
tests/test_session_anonymous_request.py(19 tests) runs real requests, including a request that carries an unknown cookie and the logout case, and fails on v3 3.13.147 without this change.