test(serve-debug): unify readiness on the Server-banner guard (parity) + fix carbon bench scss drift - #193
Merged
Conversation
…d (parity); fix carbon bench scss drift Parity: the serve-debug harness now reads identically across python/php/ruby -- clean child env (python env= filtered, the idiomatic equivalent of ruby's unsetenv_others) -> wait for the child's own 'Server: http://...:<port>' banner (the cross-framework boot banner all four print) -> poll /__dev -> retry on a fresh port. Replaces the python-only sentinel-route guard so there are no cross-framework surprises; ruby (the proven banner approach) is unchanged. PYTHONUNBUFFERED=1 so the banner reaches the log immediately. Verified 4/4 single + 12/12 under CPU load; no mocks. Carbon benchmark: bench_startup imported tina4_python.scss.compile_string, a module removed when SCSS compilation moved to the Rust CLI -- the import crashed . Dropped the dead import; the run now completes all 9 categories (SCI grade APlus each, region ZA, modelled on a host without a hardware energy counter). python-only drift; php/ruby/node benchmarks carry no scss reference. Signed-off-by: Andre van Zuydam <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]> Co-Authored-By: Tina4 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parity (the point)
The serve-debug harness now reads identically across python/php/ruby — no cross-framework surprises:
clean child env (python
env=filtered — the idiomatic equivalent of ruby'sunsetenv_others) → wait for the child's ownServer: http://…:<port>banner (the boot banner all four frameworks print) → poll/__dev→ retry on a fresh port.This replaces the python-only sentinel-route guard I'd added (speculative — python was never vulnerable to the ruby-only ENV-inheritance flake, since
env=already replaces the environment). Ruby's proven banner approach is unchanged; python/php now match it.PYTHONUNBUFFERED=1so the banner reaches the log immediately. Verified 4/4 single, 12/12 under CPU load; no mocks.Carbon benchmark drift fix
bench_startup()importedtina4_python.scss.compile_string— a module removed when SCSS compilation moved to the Rust CLI — which crashedcarbon_benchmarks.py --carbon. Dropped the dead import; the run now completes all 9 categories (SCI grade APlus each, region ZA, modelled on a host without a hardware energy counter). Python-only drift (php/ruby/node benchmarks carry no scss reference).🤖 Generated with Claude Code