Repository navigation
Fix polygon / collection containment involving boundary points and nested empties - #35
Merged
tidwall merged 15 commits intoOct 5, 2026
Merged
Conversation
* add the first failing case * add some failing comented out cases * uncomment them * generated change * remove the multiline cases and start from main * implement contains with with min dim handling * touches update * fix remaining within/contains cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with me.
Please ensure you adhere to every item in this list
Describe your changes
This changes polygon containment of collections to use a recursive walk of the non-collection leaves to check emptiness, return early for geometries that aren't covered, but keep iterating until at least one non-boundary containment is found.
Technically this implementation repeats some work for nested collections (Codex suggested a recursive warlk of leaf geometries, which I'm happy to do as well).
Issue number and link
This one surfaced from a SedonaDB test:
apache/sedona-db#1165 (comment)